[jira] [Commented] (BATIK-1170) [PATCH] Workaround for incorrect ColorConvertOp alpha handling breaks masking

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (BATIK-1170) [PATCH] Workaround for incorrect ColorConvertOp alpha handling breaks masking

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/BATIK-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095905#comment-16095905 ]

Alex Berg commented on BATIK-1170:
----------------------------------

Issue with ring mask not converting correctly is still present in Batik-1.9, using Oracle Java 8u131x64 windows, see also https://issues.apache.org/jira/browse/BATIK-1156.

> [PATCH] Workaround for incorrect ColorConvertOp alpha handling breaks masking
> -----------------------------------------------------------------------------
>
>                 Key: BATIK-1170
>                 URL: https://issues.apache.org/jira/browse/BATIK-1170
>             Project: Batik
>          Issue Type: Bug
>    Affects Versions: 1.8
>            Reporter: Jan Tošovský
>         Attachments: BATIK-1170.patch, ring_mask_after.png, ring_mask_before.png, ring_mask.svg
>
>
> There is workaround in Any2LumRed.java with this comment:
> // All this nonsense is to work around the fact that the
> // Color convert op doesn't properly copy the Alpha from
> // src to dst.
> When processing SVG with mask in Oracle JDK 8, this workaround is the root cause of several issues reported here in JIRA.
> The only related issue I've found so far is https://bugs.openjdk.java.net/browse/JDK-8005930. Can anybody confirm the comment/workaround above was targeted for OpenJDK?
> When this code is commented, the result is processed correctly (Oracle JDK). However, I am afraid this is not a proper way how to fix it as this code should produce same results for various JDKs/versions. For this we need a new boolean variable, something like isColorConvertOpAlphaSupported - the result of analyzing destination's alpha (if present or not) after running the simple ColorConvertOp test. That workaround would be applied only if alpha is not supported.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...