patch for BATIK-802

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

patch for BATIK-802

Zsolt Kúti
Hi,

Please review attached patch that resolves a bug painful for a few of us.

Thanks
Zsolt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

BATIK_802__fixed__test_added.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: patch for BATIK-802

Zsolt Kúti
A little explanation to the test. While it looks like being a unit test it is not that. CleanerThread catches everything in its run method therefore NPEs presence or absence can only be observed by way of printStacktrace code originally put there. Implementing something in CT just for the case of a test is perhaps not worth the effort.

Zsolt

On Tue, Aug 8, 2017 at 4:13 PM, Zsolt Kúti <[hidden email]> wrote:
Hi,

Please review attached patch that resolves a bug painful for a few of us.

Thanks
Zsolt

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: patch for BATIK-802

Zsolt Kúti
Hi,

Can anybody review this, please?

Thank you
Zsolt

On Tue, Aug 8, 2017 at 6:08 PM, Zsolt Kúti <[hidden email]> wrote:
A little explanation to the test. While it looks like being a unit test it is not that. CleanerThread catches everything in its run method therefore NPEs presence or absence can only be observed by way of printStacktrace code originally put there. Implementing something in CT just for the case of a test is perhaps not worth the effort.

Zsolt

On Tue, Aug 8, 2017 at 4:13 PM, Zsolt Kúti <[hidden email]> wrote:
Hi,

Please review attached patch that resolves a bug painful for a few of us.

Thanks
Zsolt


Loading...